mrkubax10/industrialtest
1
3
Fork 3
Code Issues 3 Pull Requests Packages Projects Releases 7 Wiki Activity

add sound at jetpack #29

Merged
mrkubax10 merged 4 commits from Kindaglia/industrialtest:sound into master 2025-04-25 10:48:51 +02:00
Conversation 3 Commits 4 Files Changed 2 +20 -2
Kindaglia commented 2025-04-24 21:17:40 +02:00
Contributor
Copy Link

Hy i add sound at jet pack, do you think it's okay?

Hy i add sound at jet pack, do you think it's okay?
Kindaglia added 2 commits 2025-04-24 21:17:44 +02:00
mrkubax10 requested changes 2025-04-24 23:02:30 +02:00
mrkubax10 left a comment
Owner
Copy Link

About the file JetpackLoop.ogg, please rename it to industrialtest_jetpack_loop.ogg to follow Minetest naming convention. Before I merge the pull request I would like to know what license does this sound file have if you didn't make it yourself.

About the file `JetpackLoop.ogg`, please rename it to `industrialtest_jetpack_loop.ogg` to follow Minetest naming convention. Before I merge the pull request I would like to know what license does this sound file have if you didn't make it yourself.
tools/jetpack.lua Outdated
@ -19,12 +19,30 @@ industrialtest.JetpackBase=table.copy(industrialtest.GearTool)
industrialtest.internal.unpackTableInto(industrialtest.JetpackBase,{
part="torso"
})
local sound_handles = {}
mrkubax10 commented 2025-04-24 22:59:27 +02:00
Owner
Copy Link

Rename to soundHandles

Rename to `soundHandles`
Kindaglia commented 2025-04-25 00:16:33 +02:00
Author
Contributor
Copy Link

i rename JetpackLoop to industrialtest_jetpack_loop an replace sound with sound freecopiright with Creative Commons license (https://freesound.org/people/velcronator/sounds/733985/?)

i rename JetpackLoop to industrialtest_jetpack_loop an replace sound with sound freecopiright with Creative Commons license (https://freesound.org/people/velcronator/sounds/733985/?)
mrkubax10 commented 2025-04-25 08:12:26 +02:00
Owner
Copy Link

Sure

Sure
mrkubax10 added the
enhancement
 label 2025-04-24 23:03:09 +02:00
Kindaglia added 1 commit 2025-04-25 00:15:18 +02:00
Kindaglia added 1 commit 2025-04-25 10:13:10 +02:00
Kindaglia commented 2025-04-25 10:13:38 +02:00
Author
Contributor
Copy Link

is okay now?

is okay now?
mrkubax10 commented 2025-04-25 10:48:26 +02:00
Owner
Copy Link

Seems good, thanks 👍

Seems good, thanks 👍
mrkubax10 merged commit 5898cc4e1c into master 2025-04-25 10:48:51 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mrkubax10
Labels
Clear labels
bug
Something is not working
compat-mode:mineclone2
compat-mode:minetest_game
crash
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mrkubax10
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mrkubax10/industrialtest#29
No description provided.
Delete Branch "Kindaglia/industrialtest:sound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?