Refactor utils

api/network.lua

@@ -94,7 +94,7 @@ function industrialtest.api.powerFlow(pos,sides,flowOverride)
 					def._industrialtest_self:triggerIfNeeded(endpoint.position)
 				else
 					-- Support for bare definitions that don't use industrialtest pseudo-OOP
-					minetest.get_node_timer(endpoint.position):start(industrialtest.updateDelay)
+					minetest.get_node_timer(endpoint.position):start(industrialtest.config.updateDelay)
 				end
 				if not industrialtest.api.isFullyCharged(endpointMeta) then
 					roomAvailable=true

cables.lua

@@ -15,27 +15,43 @@
 -- along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 local S=minetest.get_translator("industrialtest")
-local cable={}
 
-cable.onConstruct=function(pos)
+industrialtest.Cable={}
+
+function industrialtest.Cable.onConstruct(self,pos)
 	local connections=industrialtest.api.getConnections(pos)
 	for _,conn in ipairs(connections) do
 		local meta=minetest.get_meta(conn)
 		if industrialtest.api.isNetworkMaster(meta) then
 			industrialtest.api.createNetworkMapForNode(conn)
+			local networkNode=minetest.get_node(conn)
+			local def=minetest.registered_nodes[networkNode.name]
+			if def and def._industrialtest_self then
+				def._industrialtest_self:triggerIfNeeded(conn)
+			else
+				-- Support for bare definitions that don't use industrialtest pseudo-OOP
+				minetest.get_node_timer(conn):start(industrialtest.config.updateDelay)
+			end
 		else
 			local networks=industrialtest.api.isAttachedToNetwork(meta)
 			if networks then
 				for _,network in ipairs(networks) do
 					industrialtest.api.createNetworkMapForNode(network)
-					minetest.get_node_timer(network):start(industrialtest.updateDelay)
+					local networkNode=minetest.get_node(network)
+					local def=minetest.registered_nodes[networkNode.name]
+					if def and def._industrialtest_self then
+						def._industrialtest_self:triggerIfNeeded(network)
+					else
+						-- Support for bare definitions that don't use industrialtest pseudo-OOP
+						minetest.get_node_timer(network):start(industrialtest.config.updateDelay)
+					end
 				end
 			end
 		end
 	end
 end
 
-cable.onDestruct=function(pos)
+function industrialtest.Cable.onDestruct(self,pos)
 	local meta=minetest.get_meta(pos)
 	local networks=industrialtest.api.isAttachedToNetwork(meta)
 	if networks then
@@ -45,14 +61,16 @@ cable.onDestruct=function(pos)
 	end
 end
 
-local function registerCable(name,displayName,size,flow,registerInsulated)
-	local definition={
-		description=S(displayName.." Cable"),
-		inventory_image="industrialtest_"..name.."_cable_inv.png",
-		tiles={"industrialtest_"..name.."_cable.png"},
-		wield_image="industrialtest_"..name.."_cable_inv.png",
+function industrialtest.Cable.createDefinitionTable(self,description,inventoryImage,tile,insulated)
+	local size=(insulated and self.size+0.02 or self.size)
+	local def={
+		description=description,
+		inventory_image=inventoryImage,
+		wield_image=inventoryImage,
+		tiles={tile},
 		paramtype="light",
 		sunlight_propagates=true,
+		use_texture_alpha=(self.transparent and "clip" or "opaque"),
 		drawtype="nodebox",
 		node_box={
 			type="connected",
@@ -118,39 +136,64 @@ local function registerCable(name,displayName,size,flow,registerInsulated)
 			"group:_industrialtest_hasPowerOutput",
 			"group:_industrialtest_cable"
 		},
-		on_construct=cable.onConstruct,
-		on_destruct=cable.onDestruct,
-		_industrialtest_cableFlow=flow
+		on_construct=function(pos)
+			self:onConstruct(pos)
+		end,
+		on_destruct=function(pos)
+			self:onDestruct(pos)
+		end,
+		_industrialtest_cableFlow=self.flow
 	}
+
 	if industrialtest.mtgAvailable then
-		definition.groups={
+		def.groups={
 			cracky=1,
 			level=1,
 			oddly_breakable_by_hand=1
 		}
-		definition.sound=default.node_sound_metal_defaults()
+		def.sound=default.node_sound_metal_defaults()
 	elseif industrialtest.mclAvailable then
-		definition.groups={
+		def.groups={
 			handy=1,
 			pickaxey=1
 		}
-		definition._mcl_blast_resistance=1
-		definition._mcl_hardness=0.5
-		definition.sound=mcl_sounds.node_sound_metal_defaults()
+		def._mcl_blast_resistance=1
+		def._mcl_hardness=0.5
+		def.sound=mcl_sounds.node_sound_metal_defaults()
 	end
-	definition.groups._industrialtest_cable=1
-	minetest.register_node("industrialtest:"..name.."_cable",definition)
-	if registerInsulated then
-		definition=table.copy(definition)
-		definition.description=S("Insulated "..displayName.." Cable")
-		definition.inventory_image="industrialtest_insulated_"..name.."_cable_inv.png"
-		definition.tiles={"industrialtest_insulated_"..name.."_cable.png"}
-		definition.wield_image="industrialtest_insulated_"..name.."_cable_inv.png"
-		minetest.register_node("industrialtest:insulated_"..name.."_cable",definition)
+	def.groups._industrialtest_cable=1
+
+	return def
+end
+
+function industrialtest.Cable.register(self)
+	local def=self:createDefinitionTable(self.description,self.inventoryImage,self.tile,false)
+	minetest.register_node(self.name,def)
+
+	if self.insulated then
+		def=self:createDefinitionTable(self.insulated.description,self.insulated.inventoryImage,self.insulated.tile,true)
+		minetest.register_node(self.insulated.name,def)
 	end
 end
 
-registerCable("tin","Tin",0.19,industrialtest.api.lvPowerFlow,true)
+industrialtest.TinCable=table.copy(industrialtest.Cable)
+industrialtest.internal.unpackTableInto(industrialtest.TinCable,{
+	name="industrialtest:tin_cable",
+	description=S("Tin Cable"),
+	inventoryImage="industrialtest_tin_cable_inv.png",
+	tile="industrialtest_tin_cable.png",
+	size=0.19,
+	flow=industrialtest.api.lvPowerFlow,
+	insulated={
+		name="industrialtest:insulated_tin_cable",
+		description=S("Insulated Tin Cable"),
+		inventoryImage="industrialtest_insulated_tin_cable_inv.png",
+		tile="industrialtest_insulated_tin_cable.png"
+	}
+})
+
+industrialtest.TinCable:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:tin_cable 6",
@@ -158,6 +201,7 @@ minetest.register_craft({
 		{industrialtest.elementKeys.tinIngot,industrialtest.elementKeys.tinIngot,industrialtest.elementKeys.tinIngot}
 	}
 })
+
 minetest.register_craft({
 	type="shapeless",
 	output="industrialtest:insulated_tin_cable",
@@ -166,6 +210,7 @@ minetest.register_craft({
 		industrialtest.elementKeys.rubber
 	}
 })
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:insulated_tin_cable 6",
@@ -175,13 +220,31 @@ minetest.register_craft({
 		{industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber}
 	}
 })
+
 industrialtest.api.registerCableFormerRecipe({
 	output="industrialtest:tin_cable 12",
 	recipe=industrialtest.elementKeys.tinIngot,
 	time=1
 })
 
-registerCable("copper","Copper",0.15,industrialtest.api.mvPowerFlow,true)
+industrialtest.CopperCable=table.copy(industrialtest.Cable)
+industrialtest.internal.unpackTableInto(industrialtest.CopperCable,{
+	name="industrialtest:copper_cable",
+	description=S("Copper Cable"),
+	inventoryImage="industrialtest_copper_cable_inv.png",
+	tile="industrialtest_copper_cable.png",
+	size=0.15,
+	flow=industrialtest.api.mvPowerFlow,
+	insulated={
+		name="industrialtest:insulated_copper_cable",
+		description=S("Insulated Copper Cable"),
+		inventoryImage="industrialtest_insulated_copper_cable_inv.png",
+		tile="industrialtest_insulated_copper_cable.png"
+	}
+})
+
+industrialtest.CopperCable:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:copper_cable 6",
@@ -189,6 +252,7 @@ minetest.register_craft({
 		{industrialtest.elementKeys.copperIngot,industrialtest.elementKeys.copperIngot,industrialtest.elementKeys.copperIngot}
 	}
 })
+
 minetest.register_craft({
 	type="shapeless",
 	output="industrialtest:insulated_copper_cable",
@@ -197,6 +261,7 @@ minetest.register_craft({
 		industrialtest.elementKeys.rubber
 	}
 })
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:insulated_copper_cable 6",
@@ -206,12 +271,30 @@ minetest.register_craft({
 		{industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber}
 	}
 })
+
 industrialtest.api.registerCableFormerRecipe({
 	output="industrialtest:copper_cable 12",
 	recipe=industrialtest.elementKeys.copperIngot
 })
 
-registerCable("gold","Gold",0.15,industrialtest.api.hvPowerFlow,true)
+industrialtest.GoldCable=table.copy(industrialtest.Cable)
+industrialtest.internal.unpackTableInto(industrialtest.GoldCable,{
+	name="industrialtest:gold_cable",
+	description=S("Gold Cable"),
+	inventoryImage="industrialtest_gold_cable_inv.png",
+	tile="industrialtest_gold_cable.png",
+	size=0.15,
+	flow=industrialtest.api.hvPowerFlow,
+	insulated={
+		name="industrialtest:insulated_gold_cable",
+		description=S("Insulated Gold Cable"),
+		inventoryImage="industrialtest_insulated_gold_cable_inv.png",
+		tile="industrialtest_insulated_gold_cable.png"
+	}
+})
+
+industrialtest.GoldCable:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:gold_cable 6",
@@ -219,6 +302,7 @@ minetest.register_craft({
 		{industrialtest.elementKeys.goldIngot,industrialtest.elementKeys.goldIngot,industrialtest.elementKeys.goldIngot}
 	}
 })
+
 minetest.register_craft({
 	type="shapeless",
 	output="industrialtest:insulated_gold_cable",
@@ -227,6 +311,7 @@ minetest.register_craft({
 		industrialtest.elementKeys.rubber
 	}
 })
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:insulated_gold_cable 6",
@@ -236,12 +321,30 @@ minetest.register_craft({
 		{industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber}
 	}
 })
+
 industrialtest.api.registerCableFormerRecipe({
 	output="industrialtest:gold_cable 12",
 	recipe=industrialtest.elementKeys.goldIngot
 })
 
-registerCable("iron","Iron",0.15,industrialtest.api.evPowerFlow,true)
+industrialtest.IronCable=table.copy(industrialtest.Cable)
+industrialtest.internal.unpackTableInto(industrialtest.IronCable,{
+	name="industrialtest:iron_cable",
+	description=S("Iron Cable"),
+	inventoryImage="industrialtest_iron_cable_inv.png",
+	tile="industrialtest_iron_cable.png",
+	size=0.15,
+	flow=industrialtest.api.evPowerFlow,
+	insulated={
+		name="industrialtest:insulated_iron_cable",
+		description=S("Insulated Iron Cable"),
+		inventoryImage="industrialtest_insulated_iron_cable_inv.png",
+		tile="industrialtest_insulated_iron_cable.png"
+	}
+})
+
+industrialtest.IronCable:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:iron_cable 6",
@@ -249,6 +352,7 @@ minetest.register_craft({
 		{"industrialtest:refined_iron_ingot","industrialtest:refined_iron_ingot","industrialtest:refined_iron_ingot"}
 	}
 })
+
 minetest.register_craft({
 	type="shapeless",
 	output="industrialtest:insulated_iron_cable",
@@ -257,6 +361,7 @@ minetest.register_craft({
 		industrialtest.elementKeys.rubber
 	}
 })
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:insulated_iron_cable 6",
@@ -266,13 +371,26 @@ minetest.register_craft({
 		{industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber,industrialtest.elementKeys.rubber}
 	}
 })
+
 industrialtest.api.registerCableFormerRecipe({
 	output="industrialtest:iron_cable 12",
 	recipe="industrialtest:refined_iron_ingot",
 	time=3
 })
 
-registerCable("glass_fibre","Glass Fibre",0.15,industrialtest.api.ivPowerFlow,false)
+industrialtest.GlassFibreCable=table.copy(industrialtest.Cable)
+industrialtest.internal.unpackTableInto(industrialtest.GlassFibreCable,{
+	name="industrialtest:glass_fibre_cable",
+	description=S("Glass Fibre Cable"),
+	inventoryImage="industrialtest_glass_fibre_cable_inv.png",
+	transparent=true,
+	tile="industrialtest_glass_fibre_cable.png",
+	size=0.12,
+	flow=industrialtest.api.ivPowerFlow
+})
+
+industrialtest.GlassFibreCable:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:glass_fibre_cable 4",

compat/pipeworks.lua

@@ -316,7 +316,8 @@ override={
 			local meta=minetest.get_meta(pos)
 			local inv=meta:get_inventory()
 			local result=inv:add_item(listname,stack)
-			minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+			local nodeDef=minetest.registered_nodes[node.name]
+			nodeDef._industrialtest_self:triggerIfNeeded(pos)
 			return result
 		end,
 		can_insert=function(pos,node,stack,direction)

init.lua

@@ -19,9 +19,11 @@ local modpath=minetest.get_modpath("industrialtest")
 -- table with global functions, variables etc
 industrialtest={}
 
--- Initial constants
-industrialtest.updateDelay=1 -- Note: Make this value smaller to make machines update more frequently (it may make server more laggy)
-industrialtest.developerMode=true -- Enables additional utils useful when developing mod
+-- Settings
+industrialtest.config={
+	updateDelay=minetest.settings:get("industrialtest.updateDelay") or 1,
+	developerMode=minetest.settings:get_bool("industrialtest.developerMode",false)
+}
 
 -- Others
 industrialtest.random=PseudoRandom(os.time())
@@ -92,7 +94,7 @@ dofile(modpath.."/tools/wrench.lua")
 dofile(modpath.."/upgrades.lua")
 dofile(modpath.."/craftitems.lua")
 dofile(modpath.."/nodes.lua")
-if industrialtest.developerMode then
+if industrialtest.config.developerMode then
 	dofile(modpath.."/utils.lua")
 end
 dofile(modpath.."/cables.lua")

machines/activated_machine.lua

@@ -66,7 +66,7 @@ function industrialtest.ActivatedMachine.activate(self,pos)
 		param2=minetest.get_node(pos).param2
 	})
 	self:afterActivation(pos)
-	minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+	minetest.get_node_timer(pos):start(industrialtest.config.updateDelay)
 end
 
 function industrialtest.ActivatedMachine.deactivate(self,pos)
@@ -75,7 +75,7 @@ function industrialtest.ActivatedMachine.deactivate(self,pos)
 		param2=minetest.get_node(pos).param2
 	})
 	self:afterDeactivation(pos)
-	minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+	minetest.get_node_timer(pos):start(industrialtest.config.updateDelay)
 end
 
 function industrialtest.ActivatedMachine.shouldActivate(self,pos)

machines/canning_machine.lua

@@ -140,7 +140,7 @@ function industrialtest.CanningMachine.allowMetadataInventoryTake(self,pos,listn
 	local targetSlot=inv:get_stack("dst",1)
 	if ((listname=="src" and stack:get_count()==fuelSlot:get_count()) or (listname=="dst" and stack:get_count()==targetSlot:get_count())) and meta:get_float("srcTime")>0 then
 		meta:set_float("srcTime",0)
-		minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+		self:updateFormspec(pos)
 	end
 	return industrialtest.ActivatedElectricMachine.allowMetadataInventoryTake(self,pos,listname,index,stack,player)
 end
@@ -153,12 +153,12 @@ function industrialtest.CanningMachine.onMetadataInventoryMove(self,pos,fromList
 	local targetSlot=inv:get_stack("dst",1)
 	if ((fromList=="src" and count==fuelSlot:get_count()) or (fromList=="dst" and count==targetSlot:get_count())) and meta:get_float("srcTime")>0 then
 		meta:set_float("srcTime",0)
-		meta:set_string("formspec",canningMachine.getFormspec(pos))
+		self:updateFormspec(pos)
 	end
 end
 
 function industrialtest.CanningMachine.onMetadataInventoryPut(self,pos,listname,index,stack)
-	minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+	self:triggerIfNeeded(pos)
 	industrialtest.ActivatedElectricMachine.onMetadataInventoryPut(self,pos,listname,index,stack)
 end
 

machines/chargepad.lua

@@ -291,7 +291,7 @@ industrialtest.MFSUChargepad:register()
 minetest.register_abm({
 	label="Chargepad updating",
 	nodenames=industrialtest.internal.chargepads,
-	interval=industrialtest.updateDelay,
+	interval=industrialtest.config.updateDelay,
 	chance=1,
 	action=function(pos,node)
 		local def=minetest.registered_nodes[node.name]

machines/electric_machine.lua

@@ -32,7 +32,7 @@ function industrialtest.ElectricMachine.onConstruct(self,pos)
 					def._industrialtest_self:flowPower(conn)
 				else
 					-- Support for bare definitions that don't use industrialtest pseudo-OOP
-					minetest.get_node_timer(conn):start(industrialtest.updateDelay)
+					minetest.get_node_timer(conn):start(industrialtest.config.updateDelay)
 				end
 			else
 				local def=minetest.registered_nodes[minetest.get_node(conn).name]
@@ -46,7 +46,7 @@ function industrialtest.ElectricMachine.onConstruct(self,pos)
 								def._industrialtest_self:flowPower(network)
 							else
 								-- Support for bare definitions that don't use industrialtest pseudo-OOP
-								minetest.get_node_timer(network):start(industrialtest.updateDelay)
+								minetest.get_node_timer(network):start(industrialtest.config.updateDelay)
 							end
 						end
 					end
@@ -177,7 +177,7 @@ function industrialtest.ElectricMachine.requestPower(self,pos)
 				def._industrialtest_self:flowPower(network)
 			else
 				-- Support for bare definitions that don't use industrialtest pseudo-OOP
-				minetest.get_node_timer(network):start(industrialtest.updateDelay)
+				minetest.get_node_timer(network):start(industrialtest.config.updateDelay)
 			end
 		end
 	end

machines/fluid_generator.lua

@@ -366,7 +366,7 @@ minetest.register_abm({
 	label="Water Mill generating",
 	nodenames={"industrialtest:water_mill"},
 	neighbors=neighbors,
-	interval=industrialtest.updateDelay,
+	interval=industrialtest.config.updateDelay,
 	chance=1,
 	action=function(pos)
 		industrialtest.WaterMill:action(pos)

machines/generator.lua

@@ -19,7 +19,7 @@ industrialtest.Generator=table.copy(industrialtest.ActivatedElectricMachine)
 industrialtest.internal.unpackTableInto(industrialtest.Generator,{
 	name="industrialtest:generator",
 	description=S("Generator"),
-		tiles={
+	tiles={
 		"industrialtest_machine_block.png",
 		"industrialtest_machine_block.png",
 		"industrialtest_machine_block.png",
@@ -85,7 +85,7 @@ function industrialtest.Generator.getFormspec(self,pos)
 end
 
 function industrialtest.Generator.onMetadataInventoryPut(self,pos,listname,index,stack)
-	minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+	self:triggerIfNeeded(pos)
 	industrialtest.ActivatedElectricMachine.onMetadataInventoryPut(self,pos,listname,index,stack)
 end
 

machines/iron_furnace.lua

@@ -131,7 +131,7 @@ function industrialtest.IronFurnace.allowMetadataInventoryTake(self,pos,listname
 			self:updateFormspec(pos)
 		end
 	elseif listname=="dst" and dstSlot:get_free_space()==0 then
-		minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+		self:triggerIfNeeded(pos)
 	end
 	return industrialtest.ActivatedMachine.allowMetadataInventoryTake(self,pos,listname,index,stack)
 end
@@ -148,13 +148,13 @@ function industrialtest.IronFurnace.onMetadataInventoryMove(self,pos,fromList,fr
 			self:updateFormspec(pos)
 		end
 	elseif fromList=="dst" and dstSlot:get_free_space()==0 then
-		minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+		self:triggerIfNeeded(pos)
 	end
 	industrialtest.ActivatedMachine.onMetadataInventoryMove(self,pos,fromList,fromIndex,toList,toIndex,count)
 end
 
 function industrialtest.IronFurnace.onMetadataInventoryPut(self,pos,listname,index,stack)
-	minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+	self:triggerIfNeeded(pos)
 	industrialtest.ActivatedMachine.onMetadataInventoryPut(self,pos,listname,index,stack)
 end
 

machines/machine.lua

@@ -73,7 +73,7 @@ end
 function industrialtest.Machine.trigger(self,pos)
 	local timer=minetest.get_node_timer(pos)
 	if not timer:is_started() then
-		timer:start(industrialtest.updateDelay)
+		timer:start(industrialtest.config.updateDelay)
 	end
 end
 
@@ -128,27 +128,37 @@ function industrialtest.Machine.onMetadataInventoryMove(self,pos,fromList,fromIn
 	if toList=="upgrades" then
 		local meta=minetest.get_meta(pos)
 		local inv=meta:get_inventory()
-		local stack=inv:get_stack(fromList,fromIndex)
-		industrialtest.internal.applyUpgrade(pos,meta,stack)
+		local itemstack=inv:get_stack(fromList,fromIndex)
+		local def=itemstack:get_definition()
+		if def and def._industrialtest_self and def._industrialtest_self.apply then
+			def._industrialtest_self:apply(pos)
+		end
 	elseif fromList=="upgrades" then
 		local meta=minetest.get_meta(pos)
 		local inv=meta:get_inventory()
-		local stack=inv:get_stack(fromList,fromIndex)
-		industrialtest.internal.removeUpgrade(pos,meta,stack)
+		local itemstack=inv:get_stack(fromList,fromIndex)
+		local def=itemstack:get_definition()
+		if def and def._industrialtest_self and def._industrialtest_self.remove then
+			def._industrialtest_self:remove(pos)
+		end
 	end
 end
 
 function industrialtest.Machine.onMetadataInventoryPut(self,pos,listname,index,stack)
 	if listname=="upgrades" then
-		local meta=minetest.get_meta(pos)
-		industrialtest.internal.applyUpgrade(pos,meta,stack)
+		local def=stack:get_definition()
+		if def and def._industrialtest_self and def._industrialtest_self.apply then
+			def._industrialtest_self:apply(pos)
+		end
 	end
 end
 
 function industrialtest.Machine.onMetadataInventoryTake(self,pos,listname,index,stack)
 	if listname=="upgrades" then
-		local meta=minetest.get_meta(pos)
-		industrialtest.internal.removeUpgrade(pos,meta,stack)
+		local def=stack:get_definition()
+		if def and def._industrialtest_self and def._industrialtest_self.remove then
+			def._industrialtest_self:remove(pos)
+		end
 	end
 end
 
@@ -259,7 +269,7 @@ function industrialtest.Machine.createDefinitionTable(self)
 			return inv, "src", mcl_util.select_stack(hop_inv, hop_list, inv, "src")
 		end
 		def._mcl_hoppers_on_after_push=function(pos)
-			minetest.get_node_timer(pos):start(industrialtest.updateDelay)
+			self:triggerIfNeeded(pos)
 		end
 	end
 
@@ -289,8 +299,8 @@ function industrialtest.Machine.register(self)
 	industrialtest.api.addTag(self.name,"usesTimer")
 end
 
-function industrialtest.Machine.allowMoveToUpgradeSlot(pos,toIndex,stack)
-	local def=minetest.registered_items[stack:get_name()]
+function industrialtest.Machine.allowMoveToUpgradeSlot(pos,toIndex,itemstack)
+	local def=itemstack:get_definition()
 	if not def or not def.groups or not def.groups._industrialtest_machineUpgrade then
 		return 0
 	end
@@ -300,5 +310,5 @@ function industrialtest.Machine.allowMoveToUpgradeSlot(pos,toIndex,stack)
 	if not targetSlot:is_empty() then
 		return 0
 	end
-	return stack:get_count()
+	return itemstack:get_count()
 end

machines/simple_electric_item_processor.lua

@@ -107,8 +107,8 @@ function industrialtest.SimpleElectricItemProcessor.onMetadataInventoryMove(self
 	end
 end
 
-function industrialtest.SimpleElectricItemProcessor.onMetadataInventoryPut(self,pos)
-	industrialtest.ActivatedElectricMachine.onMetadataInventoryPut(self,pos)
+function industrialtest.SimpleElectricItemProcessor.onMetadataInventoryPut(self,pos,listname,index,stack)
+	industrialtest.ActivatedElectricMachine.onMetadataInventoryPut(self,pos,listname,index,stack)
 	self:triggerIfNeeded(pos)
 end
 

machines/solar_panel_generator.lua

@@ -193,7 +193,7 @@ minetest.register_craft({
 minetest.register_abm({
 	name="Solar panel updating",
 	nodenames=solarPanels,
-	interval=industrialtest.updateDelay,
+	interval=industrialtest.config.updateDelay,
 	chance=1,
 	action=function(pos,node)
 		local def=minetest.registered_nodes[node.name]

machines/wind_mill.lua

@@ -122,7 +122,7 @@ minetest.register_craft({
 minetest.register_abm({
 	name="Wind mill updating",
 	nodenames={"industrialtest:wind_mill"},
-	interval=industrialtest.updateDelay,
+	interval=industrialtest.config.updateDelay,
 	chance=1,
 	action=function(pos)
 		industrialtest.WindMill:action(pos)

settingtypes.txt

@@ -0,0 +1,5 @@
+# This determines value how frequently machines update
+industrialtest.updateDelay (Update delay) float 1.0
+
+# Enables additional utils useful when developing mod
+industrialtest.developerMode (Developer mode) bool false

tools/batpack.lua

@@ -23,7 +23,7 @@ industrialtest.internal.unpackTableInto(industrialtest.BatPackBase,{
 local updateDelta=0
 function industrialtest.BatPackBase.update(self,player,inv,itemstack,dtime)
 	updateDelta=updateDelta+dtime
-	if updateDelta<industrialtest.updateDelay then
+	if updateDelta<industrialtest.config.updateDelay then
 		return false
 	end
 	updateDelta=0

tools/quantum_suit.lua

@@ -45,7 +45,7 @@ industrialtest.internal.unpackTableInto(industrialtest.QuantumHelmet,{
 local quantumHelmetUpdateDelta=0
 function industrialtest.QuantumHelmet.update(self,player,inv,itemstack,dtime)
 	quantumHelmetUpdateDelta=quantumHelmetUpdateDelta+dtime
-	if quantumHelmetUpdateDelta<industrialtest.updateDelay then
+	if quantumHelmetUpdateDelta<industrialtest.config.updateDelay then
 		return false
 	end
 	quantumHelmetUpdateDelta=0

tools/solar_helmet.lua

@@ -27,7 +27,7 @@ industrialtest.internal.unpackTableInto(industrialtest.SolarHelmet,{
 local updateDelta=0
 function industrialtest.SolarHelmet.update(self,player,inv,itemstack,dtime)
 	updateDelta=updateDelta+dtime
-	if updateDelta<industrialtest.updateDelay then
+	if updateDelta<industrialtest.config.updateDelay then
 		return false
 	end
 	updateDelta=0

upgrades.lua

@@ -16,106 +16,56 @@
 
 local S=minetest.get_translator("industrialtest")
 
-industrialtest.internal.applyUpgrade=function(pos,meta,stack)
-	local def=minetest.registered_items[stack:get_name()]
-	if def.groups._industrialtest_upgradeSpeed then
-		local speed=industrialtest.api.getMachineSpeed(meta)
-		meta:set_int("industrialtest.speed",math.min(4,speed+def.groups._industrialtest_upgradeSpeed))
-	elseif def.groups._industrialtest_upgradeTransformer then
-		local flows={
-			industrialtest.api.lvPowerFlow,
-			industrialtest.api.mvPowerFlow,
-			industrialtest.api.hvPowerFlow,
-			industrialtest.api.evPowerFlow,
-			industrialtest.api.ivPowerFlow
-		}
-		local machineFlow=meta:get_int("industrialtest.powerFlow")
-		local upgradedFlow=machineFlow
-		for _,flow in ipairs(flows) do
-			if flow>machineFlow then
-				upgradedFlow=flow
-				break
-			end
-		end
-		meta:set_int("industrialtest.powerFlow",upgradedFlow)
-		local networks=industrialtest.api.isAttachedToNetwork(meta)
-		if networks then
-			for _,network in ipairs(networks) do
-				industrialtest.api.createNetworkMapForNode(network)
-			end
-		end
-	elseif def.groups._industrialtest_upgradePowerStorage then
-		meta:set_int("industrialtest.powerCapacity",meta:get_int("industrialtest.powerCapacity")+10000)
-		local nodeDef=minetest.registered_nodes[minetest.get_node(pos).name]
-		if nodeDef._industrialtest_updateFormspec then
-			nodeDef._industrialtest_updateFormspec(pos)
-		end
-		local networks=industrialtest.api.isAttachedToNetwork(meta)
-		if networks then
-			for _,network in ipairs(networks) do
-				minetest.get_node_timer(network):start(industrialtest.updateDelay)
-			end
-		end
-	end
-end
+industrialtest.Upgrade={}
 
-industrialtest.internal.removeUpgrade=function(pos,meta,stack)
-	local def=minetest.registered_items[stack:get_name()]
-	if def.groups._industrialtest_upgradeSpeed and meta:contains("industrialtest.speed") then
-		local speed=meta:get_int("industrialtest.speed")
-		meta:set_int("industrialtest.speed",math.max(1,speed-def.groups._industrialtest_upgradeSpeed))
-	elseif def.groups._industrialtest_upgradeTransformer then
-		local flows={
-			industrialtest.api.lvPowerFlow,
-			industrialtest.api.mvPowerFlow,
-			industrialtest.api.hvPowerFlow,
-			industrialtest.api.evPowerFlow,
-			industrialtest.api.ivPowerFlow
-		}
-		local machineFlow=meta:get_int("industrialtest.powerFlow")
-		local downgradedFlow=machineFlow
-		for i=#flows,1,-1 do
-			local flow=flows[i]
-			if flow<machineFlow then
-				downgradedFlow=flow
-				break
-			end
-		end
-		meta:set_int("industrialtest.powerFlow",downgradedFlow)
-		local networks=industrialtest.api.isAttachedToNetwork(meta)
-		if networks then
-			for _,network in ipairs(networks) do
-				minetest.get_node_timer(network):start(industrialtest.updateDelay)
-			end
-		end
-	elseif def.groups._industrialtest_upgradePowerStorage then
-		meta:set_int("industrialtest.powerCapacity",meta:get_int("industrialtest.powerCapacity")-10000)
-		meta:set_int("industrialtest.powerAmount",math.min(meta:get_int("industrialtest.powerAmount"),meta:get_int("industrialtest.powerCapacity")))
-		local nodeDef=minetest.registered_nodes[minetest.get_node(pos).name]
-		if nodeDef._industrialtest_updateFormspec then
-			nodeDef._industrialtest_updateFormspec(pos)
-		end
-	end
-end
-
-local function registerMachineUpgrade(config)
-	minetest.register_craftitem("industrialtest:"..config.name,{
-		description=config.displayName,
-		inventory_image="industrialtest_"..config.name..".png",
+function industrialtest.Upgrade.createDefinitionTable(self)
+	local def={
+		description=self.description,
+		inventory_image=self.inventoryImage,
 		groups={
-			_industrialtest_machineUpgrade=1,
-			_industrialtest_upgradeSpeed=config.speed or nil,
-			_industrialtest_upgradeTransformer=config.transformer or nil,
-			_industrialtest_upgradePowerStorage=config.powerStorage or nil,
-		}
-	})
+			_industrialtest_machineUpgrade=1
+		},
+		_industrialtest_self=self
+	}
+
+	return def
 end
 
-registerMachineUpgrade({
-	name="overclocker_upgrade",
-	displayName=S("Overclocker Upgrade"),
-	speed=1
+function industrialtest.Upgrade.register(self)
+	local def=self:createDefinitionTable()
+	minetest.register_craftitem(self.name,def)
+end
+
+function industrialtest.Upgrade.apply(self,pos)
+	-- dummy function
+end
+
+function industrialtest.Upgrade.remove(self,pos)
+	-- dummy function
+end
+
+industrialtest.OverclockerUpgrade=table.copy(industrialtest.Upgrade)
+industrialtest.internal.unpackTableInto(industrialtest.OverclockerUpgrade,{
+	name="industrialtest:overclocker_upgrade",
+	description=S("Overclocker Upgrade"),
+	inventoryImage="industrialtest_overclocker_upgrade.png",
+	_speed=1
 })
+
+function industrialtest.OverclockerUpgrade.apply(self,pos)
+	local meta=minetest.get_meta(pos)
+	local speed=industrialtest.api.getMachineSpeed(meta)
+	meta:set_int("industrialtest.speed",math.min(4,speed+self._speed))
+end
+
+function industrialtest.OverclockerUpgrade.remove(self,pos)
+	local meta=minetest.get_meta(pos)
+	local speed=industrialtest.api.getMachineSpeed(meta)
+	meta:set_int("industrialtest.speed",math.max(1,speed-self._speed))
+end
+
+industrialtest.OverclockerUpgrade:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:overclocker_upgrade",
@@ -125,11 +75,68 @@ minetest.register_craft({
 	}
 })
 
-registerMachineUpgrade({
-	name="transformer_upgrade",
-	displayName=S("Transformer Upgrade"),
-	transformer=1
+industrialtest.TransformerUpgrade=table.copy(industrialtest.Upgrade)
+industrialtest.internal.unpackTableInto(industrialtest.TransformerUpgrade,{
+	name="industrialtest:transformer_upgrade",
+	description=S("Transformer Upgrade"),
+	inventoryImage="industrialtest_transformer_upgrade.png"
 })
+
+function industrialtest.TransformerUpgrade.apply(self,pos)
+	local meta=minetest.get_meta(pos)
+	local flows={
+		industrialtest.api.lvPowerFlow,
+		industrialtest.api.mvPowerFlow,
+		industrialtest.api.hvPowerFlow,
+		industrialtest.api.evPowerFlow,
+		industrialtest.api.ivPowerFlow
+	}
+	local machineFlow=meta:get_int("industrialtest.powerFlow")
+	local upgradedFlow=machineFlow
+	for _,flow in ipairs(flows) do
+		if flow>machineFlow then
+			upgradedFlow=flow
+			break
+		end
+	end
+	meta:set_int("industrialtest.powerFlow",upgradedFlow)
+	local networks=industrialtest.api.isAttachedToNetwork(meta)
+	if networks then
+		for _,network in ipairs(networks) do
+			industrialtest.api.createNetworkMapForNode(network)
+		end
+	end
+end
+
+function industrialtest.TransformerUpgrade.remove(self,pos)
+	local meta=minetest.get_meta(pos)
+	local flows={
+		industrialtest.api.lvPowerFlow,
+		industrialtest.api.mvPowerFlow,
+		industrialtest.api.hvPowerFlow,
+		industrialtest.api.evPowerFlow,
+		industrialtest.api.ivPowerFlow
+	}
+	local machineFlow=meta:get_int("industrialtest.powerFlow")
+	local downgradedFlow=machineFlow
+	for i=#flows,1,-1 do
+		local flow=flows[i]
+		if flow<machineFlow then
+			downgradedFlow=flow
+			break
+		end
+	end
+	meta:set_int("industrialtest.powerFlow",downgradedFlow)
+	local networks=industrialtest.api.isAttachedToNetwork(meta)
+	if networks then
+		for _,network in ipairs(networks) do
+			industrialtest.api.createNetworkMapForNode(network)
+		end
+	end
+end
+
+industrialtest.TransformerUpgrade:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:transformer_upgrade",
@@ -140,11 +147,40 @@ minetest.register_craft({
 	}
 })
 
-registerMachineUpgrade({
-	name="power_storage_upgrade",
-	displayName=S("Power Storage Upgrade"),
-	powerStorage=1
+industrialtest.PowerStorageUpgrade=table.copy(industrialtest.Upgrade)
+industrialtest.internal.unpackTableInto(industrialtest.PowerStorageUpgrade,{
+	name="industrialtest:power_storage_upgrade",
+	description=S("Power Storage Upgrade"),
+	inventoryImage="industrialtest_power_storage_upgrade.png",
+	_storage=10000
 })
+
+function industrialtest.PowerStorageUpgrade.apply(self,pos)
+	local meta=minetest.get_meta(pos)
+	meta:set_int("industrialtest.powerCapacity",meta:get_int("industrialtest.powerCapacity")+self._storage)
+	local node=minetest.get_node(pos)
+	local def=minetest.registered_nodes[node.name]
+	if def._industrialtest_self then
+		def._industrialtest_self:updateFormspec(pos)
+		if def._industrialtest_self.requestPower then
+			def._industrialtest_self:requestPower(pos)
+		end
+	end
+end
+
+function industrialtest.PowerStorageUpgrade.remove(self,pos)
+	local meta=minetest.get_meta(pos)
+	meta:set_int("industrialtest.powerCapacity",meta:get_int("industrialtest.powerCapacity")-self._storage)
+	meta:set_int("industrialtest.powerAmount",math.min(meta:get_int("industrialtest.powerAmount"),meta:get_int("industrialtest.powerCapacity")))
+	local node=minetest.get_node(pos)
+	local def=minetest.registered_nodes[node.name]
+	if def._industrialtest_self then
+		def._industrialtest_self:updateFormspec(pos)
+	end
+end
+
+industrialtest.PowerStorageUpgrade:register()
+
 minetest.register_craft({
 	type="shaped",
 	output="industrialtest:power_storage_upgrade",

utils.lua

@@ -19,30 +19,39 @@ local S=minetest.get_translator("industrialtest")
 local powerStorageInspectorContext={}
 local function inspectNode(pos,playerName)
 	local meta=minetest.get_meta(pos)
+	local sides={"X-","X+","Y-","Y+","Z-","Z+"}
 	local powerCapacity=meta:get_int("industrialtest.powerCapacity")
 	local powerFlow=meta:get_int("industrialtest.powerFlow")
 	local powerAmount=meta:get_int("industrialtest.powerAmount")
-	local powerIOConfig=meta:get_string("industrialtest.ioConfig")
+	local powerIOConfig
+	if industrialtest.api.isExtendedIoConfig(meta) then
+		powerIOConfig="\n"
+		local ioConfig=minetest.deserialize(meta:get_string("industrialtest.ioConfig"))
+		for i,config in ipairs(ioConfig) do
+			powerIOConfig=powerIOConfig..sides[i].." "..config.mode.." "..config.flow.."\n"
+		end
+	else
+		powerIOConfig=meta:get_string("industrialtest.ioConfig")
+	end
 	local formspec={
 		"formspec_version[4]",
-		"size[8,8]",
+		"size[15,15]",
 		"label[0.5,0.5;"..S("Power Storage Inspector").."]",
 		"label[0.5,1.5;"..S("Power Capacity: @1",powerCapacity).."]",
 		"label[0.5,1.9;"..S("Power Flow: @1",powerFlow).."]",
 		"label[0.5,2.3;"..S("Power Amount: @1",powerAmount).."]",
 		"label[0.5,2.7;"..S("Power IO Config: @1",powerIOConfig).."]",
-		"field[0.5,3.7;2,0.5;powerCapacity;"..S("Power Capacity")..";"..powerCapacity.."]",
-		"field[0.5,4.5;2,0.5;powerFlow;"..S("Power Flow")..";"..powerFlow.."]",
-		"field[0.5,5.4;2,0.5;powerAmount;"..S("Power Amount")..";"..powerAmount.."]",
-		"field[0.5,6.2;2,0.5;powerIOConfig;"..S("Power IO Config")..";"..powerIOConfig.."]",
-		"button[0.5,6.8;2,0.5;update;"..S("Update").."]",
+		"field[0.5,7.0;2,0.5;powerCapacity;"..S("Power Capacity")..";"..powerCapacity.."]",
+		"field[0.5,8.0;2,0.5;powerFlow;"..S("Power Flow")..";"..powerFlow.."]",
+		"field[0.5,9.0;2,0.5;powerAmount;"..S("Power Amount")..";"..powerAmount.."]",
+		"field[0.5,10.0;2,0.5;powerIOConfig;"..S("Power IO Config")..";"..meta:get_string("industrialtest.ioConfig").."]",
+		"button[0.5,11.0;2,0.5;update;"..S("Update").."]",
 		"label[4.2,2.25;"..S("Connections:").."]"
 	}
 	local connections=industrialtest.api.getConnections(pos)
-	local sides={"X-","X+","Y-","Y+","Z-","Z+"}
 	local sideString=""
-	for _,value in ipairs(connections) do
-		sideString=sideString.."("..value.x..", "..value.y..", "..value.z..")\n"
+	for i,value in ipairs(connections) do
+		sideString=sideString..sides[i].." ("..value.x..", "..value.y..", "..value.z..")\n"
 	end
 	table.insert(formspec,"label[4.2,2.65;"..sideString.."]")
 	powerStorageInspectorContext[playerName]=pos
@@ -71,7 +80,11 @@ minetest.register_on_player_receive_fields(function(player,formname,fields)
 		meta:set_int("industrialtest.powerCapacity",tonumber(fields.powerCapacity))
 		meta:set_int("industrialtest.powerFlow",tonumber(fields.powerFlow))
 		meta:set_int("industrialtest.powerAmount",tonumber(fields.powerAmount))
-		meta:set_string("industrialtest.powerIOConfig",fields.powerIOConfig)
+		if industrialtest.api.isExtendedIoConfig(meta) then
+			meta:set_string("industrialtest.powerIOConfig",minetest.serialize(fields.powerIOConfig))
+		else
+			meta:set_string("industrialtest.powerIOConfig",fields.powerIOConfig)
+		end
 		local def=minetest.registered_nodes[minetest.get_node(context).name]
 		if def and def._industrialtest_updateFormspec then
 			def._industrialtest_updateFormspec(context)